13535775647
72%
master: 62%

Ran 26 Feb 2025 03:18AM UTC

Jobs 10

Files 3

Run time 1min

Badge

Embed ▾

Committed 26 Feb 2025 03:16AM UTC coverage: 73.085% (+0.7%) from 72.349%

Build # 13535775647

Build Type

push

github

Committed by

web-flow

Commit Message

patch: improve validation of ed diffs

* Make more of an effort to reject patches where line addresses are not valid
* Reading over the ed command parser in Patch::Ed::apply(), the regex assignment was not always correct
* test1: "19,0d" command was incorrectly interpreted as "19,19d" thanks to the '||' operator
* test2: "19,18d" command was accepted, but the range is backwards
* test3: "0,19d" command was accepted, but address 0 is not allowed for "d"
* test4: "0,19c" command was accepted, but address 0 is not allowed for "c"
* I tested this by skipping to PLAN_J, using a modified diff with an update on line1 (ed command 0a is valid and means append after line 0)
* Modifying elements of the diff input, I could trigger the new validation errors

%perl diff -e env env2 | perl tee env.diff
19,20d
5,8c
META DATA
AND MORE
.
0a
#NEW LINE 1!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
.

Coverage Stats

353 of 483 relevant lines covered (73.08%)

46898.09 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
1	13535775647.1	26 Feb 2025 03:18AM UTC	3	72.35	GitHub Action Run
2	13535775647.2	26 Feb 2025 03:18AM UTC	3	72.35	GitHub Action Run
3	13535775647.3	26 Feb 2025 03:18AM UTC	3	72.35	GitHub Action Run
4	13535775647.4	26 Feb 2025 03:18AM UTC	3	72.35	GitHub Action Run
5	13535775647.5	26 Feb 2025 03:18AM UTC	3	72.35	GitHub Action Run
6	13535775647.6	26 Feb 2025 03:18AM UTC	3	72.35	GitHub Action Run
7	13535775647.7	26 Feb 2025 03:18AM UTC	3	72.35	GitHub Action Run
8	13535775647.8	26 Feb 2025 03:18AM UTC	3	72.35	GitHub Action Run
9	13535775647.9	26 Feb 2025 03:18AM UTC	3	72.35	GitHub Action Run
10	13535775647.10	26 Feb 2025 03:18AM UTC	3	72.35	GitHub Action Run

mknos / PerlPowerTools / 13535775647
72%
master: 62%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 13535775647

mknos / PerlPowerTools / 13535775647 72% master: 62%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 13535775647

mknos / PerlPowerTools / 13535775647
72%
master: 62%

README BADGES
x