babelfish-for-postgresql / babelfish_extensions / 13526741565

77%

push

github

Override max length of 0 for char parameter types in an RPC (#3515)

In a TDS remote procedure call (RPC), the max length of char based
datatypes can be 0 - 8000. The typmod of the base PG type that we map the
RPC parameter to is directly related to the max length of the parameter
type specified in the RPC. For char/varchar typmod = maxLen and for
nchar/nvarchar typmod = maxLen / 2. Thus, if maxLen = 0, we will
translate it to typmod of 0 which is invalid for char based types in PG.

To fix this, if the max length of the RPC parameter on the wire is 0, we
will override the max length to the maximum permissible length of PG
char types i.e. 8000.

Task: BABEL-5639

Signed-off-by: Sharu Goel <goelshar@amazon.com>

1 of 2 new or added lines in 1 file covered. (50.0%)

47140 of 62842 relevant lines covered (75.01%)

184438.25 hits per line