• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

payjoin / rust-payjoin / 13524514317
83%

Build:
DEFAULT BRANCH: master
Ran 25 Feb 2025 03:15PM UTC
Jobs 1
Files 38
Run time 17min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

25 Feb 2025 03:12PM UTC coverage: 79.302% (+0.3%) from 79.045%
13524514317

push

github

web-flow
Make payjoin-cli v1 / v2 features additive (#538)

Fix #500 

Following @nothingmuch's suggestion:

> 1. make appconfig more hierarchical, and support both v1 and v2
specific options in sub-structures, that are not feature gated. also
move bitcoind related stuff to its own substructure
>
> 2. out of appconfig, generate helper stuff, again i was focused on a
struct representing bitcoind (or more generally wallet) capabilities for
payjoin, to avoid needing to impl the `bitcoind` method in the trait
impls and to hide the details (e.g. error checking, psbt parsing, etc)
from the actual App impls, optimizing readability to correspond high
level description of the spec
>
> 3. adding an explicit --prefer-bip-78 or option, or something similar,
for payjoin-cli compiled with both. due to the backwards compatibility
of bip77 that probably requires more than one flag or something that is
not just boolean valued, e.g. as a sender be able to send bip78 only
even to a bip77 receiver and even if v2 support is compiled can be
useful for e2e testing with a single build
>

I think we're much closer to @nothingmuch's goal:

> my goal was making sure both app/v{1,2}.rs kind of give a high level
overview of both the protocol and the code, de-emphasizing the details
like how to talk to bitcoind and emphasizing its role as a reference
implementation for bip 77 specifically.

Perhaps some network details could still be abstracted away to make this
even more clear. But in terms of repaying tech debt and fixing the devex
by making features additive, this should be complete.

370 of 430 new or added lines in 6 files covered. (86.05%)

4157 of 5242 relevant lines covered (79.3%)

878.15 hits per line

New Missed Lines in Diff

Lines Coverage ∆ File
2
98.99
-1.01% payjoin-cli/src/main.rs
7
79.77
1.65% payjoin-cli/src/app/v1.rs
7
94.12
payjoin-cli/src/app/wallet.rs
13
76.06
0.55% payjoin-cli/src/app/v2.rs
31
81.92
-13.63% payjoin-cli/src/app/config.rs
Jobs
ID Job ID Ran Files Coverage
1 13524514317.1 25 Feb 2025 03:15PM UTC 38
79.3
GitHub Action Run
Source Files on build 13524514317
  • Tree
  • List 38
  • Changed 17
  • Source Changed 5
  • Coverage Changed 5
Coverage ∆ File Lines Relevant Covered Missed Hits/Line
  • Back to Repo
  • Github Actions Build #13524514317
  • 8777c16f on github
  • Prev Build on master (#13467719148)
  • Next Build on master (#13637705402)
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc