payjoin / rust-payjoin / 13524514317

83%

push

github

Make payjoin-cli v1 / v2 features additive (#538)

Fix #500 

Following @nothingmuch's suggestion:

> 1. make appconfig more hierarchical, and support both v1 and v2
specific options in sub-structures, that are not feature gated. also
move bitcoind related stuff to its own substructure
>
> 2. out of appconfig, generate helper stuff, again i was focused on a
struct representing bitcoind (or more generally wallet) capabilities for
payjoin, to avoid needing to impl the `bitcoind` method in the trait
impls and to hide the details (e.g. error checking, psbt parsing, etc)
from the actual App impls, optimizing readability to correspond high
level description of the spec
>
> 3. adding an explicit --prefer-bip-78 or option, or something similar,
for payjoin-cli compiled with both. due to the backwards compatibility
of bip77 that probably requires more than one flag or something that is
not just boolean valued, e.g. as a sender be able to send bip78 only
even to a bip77 receiver and even if v2 support is compiled can be
useful for e2e testing with a single build
>

I think we're much closer to @nothingmuch's goal:

> my goal was making sure both app/v{1,2}.rs kind of give a high level
overview of both the protocol and the code, de-emphasizing the details
like how to talk to bitcoind and emphasizing its role as a reference
implementation for bip 77 specifically.

Perhaps some network details could still be abstracted away to make this
even more clear. But in terms of repaying tech debt and fixing the devex
by making features additive, this should be complete.

370 of 430 new or added lines in 6 files covered. (86.05%)

4157 of 5242 relevant lines covered (79.3%)

878.15 hits per line