Ouranosinc / figanos / 13506883248

8%

Build Type

push

github

Committed by web-flow

Commit Message

Hatchmap and scattermap fixes (#195)

<!-- Please ensure the PR fulfills the following requirements! -->
<!-- If this is your first PR, make sure to add your details to the
AUTHORS.rst! -->
### Pull Request Checklist:
- [ ] This PR addresses an already opened issue (for bug fixes /
features)
  - This PR fixes #xyz
- [ ] (If applicable) Documentation has been added / updated (for bug
fixes / features).
- [ ] (If applicable) Tests have been added.
- [ ] CHANGES.rst has been updated (with summary of main changes).
- [ ] Link to issue (:issue:`number`) and pull request (:pull:`number`)
has been added.

### What kind of change does this PR introduce?

Some fixes and simplification of code:
- Option ‘no legend’ in `hatchmap`.
- Ensure ‘hatches’ are passed as a list.
- `scattermap` can use `’edgecolor’` and `’egdecolors’` interchangeably
like `matplotlib.pyplot.scatter’
- removed `deepcopy` operation in `hatchmap` and `scattermap` which is
already called in `figanos.matplotlib.utils.empyt_dict(). Consequently,
helper variables are renamed (`plot_kw_pop` -> `plot_kw` in
`scattermap`; `dc` -> `plot_kw` in `hatchmap`.
- Correct `extend` to `extent`

### Does this PR introduce a breaking change?

No


### Other information:

Run Details

0 of 53 new or added lines in 1 file covered. (0.0%)

1 existing line in 1 file now uncovered.

155 of 1908 relevant lines covered (8.12%)

0.49 hits per line