rust-bitcoin / rust-bitcoin / 13503051424
83%

DEFAULT BRANCH: master
Ran
Jobs 1
Files 124
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 82.729% (-0.003%) from 82.732%
13503051424

push

github

apoelstra 
Merge rust-bitcoin/rust-bitcoin#4099: Make transaction::Version field private

<a class=hub.com/rust-bitcoin/rust-bitcoin/commit/<a class="double-link" href="https://git"><a class=hub.com/rust-bitcoin/rust-bitcoin/commit/cb270eae8e22e2121d4d6a73b34bc1919334a7ce">cb270eae8<a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/81deddd0a9523148583dc06a308c344f9f70143b"> Make transaction::Version field private (jrakibi)
<a class="double-link" href="https://github.com/rust-bitcoin/rust-bitcoin/commit/6c69b66b0d496a66a4db2f22df8ac617ed807fb3">6c69b66b0</a> Use Version constant (jrakibi)

Pull request description:

  This commit addresses #4041 by making the `transaction::Version` field private.

  This forces people to either use the associated constants (`Version::ONE/TWO/THREE`) or the `non_standard`/`from_consensus` methods for any other transaction version.

  This aligns with our approach to `block::Version`

ACKs for top commit:
  tcharding:
    ACK cb270eae8e22e2121d4d6a73b34bc1919334a7ce
  Kixunil:
    ACK cb270eae8e22e2121d4d6a73b34bc1919334a7ce

Tree-SHA512: dcf5b50df552afce42bbbfb237345db9a8c

5 of 7 new or added lines in 2 files covered. (71.43%)

21182 of 25604 relevant lines covered (82.73%)

17002.3 hits per line

Uncovered Changes

Lines Coverage ∆ File
2
76.21
 -0.47% primitives/src/transaction.rs
Jobs
ID Job ID Ran Files Coverage
1 13503051424.1 124
82.73
 GitHub Action Run
Source Files on build 13503051424