PHPCSStandards / PHP_CodeSniffer / 13496759415

78%

master: 79%

push

github

Runner: don't prefix Ruleset error notices

As things are, the `Runner` class catches any exception thrown by the Ruleset, enhances the message with an `ERROR` prefix, adds new lines and short help usage info and then re-throws this as a `DeepExitException`.

In an upcoming PR, a new `MsgCollector` class will be introduced, which will allow for both errors, as well as warnings, notices and deprecations.

This means that the `ERROR` prefix won't always be appropriate anymore.

This commit moves the `ERROR` prefix addition from the `Runner` class to the individual messages for the Exceptions being thrown in the `Ruleset` class.

Additionally, it changes the "trailing new lines" handling as the `MsgCollector` may also add new lines at the end of a message, as messages will not necessarily always be displayed via an exception (think: non-blocking deprecation notices).
So to prevent a duplicate set of new lines, any new lines which are included in the exception are trimmed off before adding the new lines desired for the Exception display.

_This is a preliminary step before introducing the `MsgCollector` to the `Ruleset` class._

8 of 9 new or added lines in 2 files covered. (88.89%)

19179 of 24803 relevant lines covered (77.33%)

76.79 hits per line