solidjs / solid / 13463524537

85%

push

github

Show double evaluation (#2411)

* Added tests for Show counting condition evaluations

The `<Show>` component evaluates its `when` condition more often than necessary, in particular it is immediately evaluated twice if the condition is true, children is specified as a function, and keyed is not specified.

#2406

* Fixes <Show> evaluating the condition twice

Adds another memo directly on `when` in `<Show>`.

#2406

* Made <Match> conditions only evaluate when needed

This removes a bug where the `when` condition of a `<Match>` was evaluated twice immediately after creation, when the condition was true, children was a function and keyed was not specified. It also removes any unnecessary conditions evaluations by creating a memo on every `when` in a `Switch`.

For example, if a `<Switch>` has two `<Match>`es with `when={a()}` and `when={b()}` respectively, then:
- `b()` is never called if `a()` is truthy (which was true also before this change),
- `a()` is never called when `b()` changes (which is new).

#2406

* changeset

917 of 1135 branches covered (80.79%)

Branch coverage included in aggregate %.

55 of 57 new or added lines in 1 file covered. (96.49%)

2321 of 2632 relevant lines covered (88.18%)

67.29 hits per line