zooniverse / front-end-monorepo / 13462745198

77%

Build Type

push

github

Committed by web-flow

Commit Message

refactor: image loading handlers (#6581)

* refactor: image loading handlers

Some changes to clean up image loading code, and speed up subject image loading.
- lib-classifier: remove `useEffect` from `useSubjectImage`, so that image loading code runs on image load, rather than waiting for the next React render cycle.
- lib-react-components: when there's no delay for `useProgressiveImage`, run the `onLoad` handler immediately, rather than waiting for the next event cycle.
- refactor `onLoad` event handlers to use `load` events, rather than `Image` objects. This brings the event handlers in line with the DOM standard.

* add mock load events to classifier tests

* fix: add frameIndex to onSubjectReady callback

* add frame index to ImageAndText viewer

Run Details

10850 of 16567 branches covered (65.49%)

Branch coverage included in aggregate %.

29 of 32 new or added lines in 6 files covered. (90.63%)

8 existing lines in 2 files now uncovered.

16951 of 20260 relevant lines covered (83.67%)

398.62 hits per line