enbility / spine-go / 13462292951

94%

Build Type

push

github

Committed by web-flow

Commit Message

Refactor bindings and subscriptions (#58)

- Refactor BindingManager and SubscriptionManager interface APIs
- Add support for read requests to NodeManagementBindingData and
NodeManagementSubscriptionData
- Exclude sending notifications for updates on NodeManagementBindingData
and NodeManagementSubscriptionData (see code comment in
`spine/feature_local.go` method `SetData` on why this is done)
- Store bindings and subscriptions in NodeManagement data structures
- Store bindings and subscriptions for local client and server features
- Only store a requested binding or subscription if the remote accepted
it
- Adding an already existing binding or subcription again will not
return an error
- On add requests, only check for proper roles, if the
`serverFeatureType` is provided on request
- Add support for deleting all bindings or subscriptions with the same
role relation by omitting feature address or also entity address
- Add support for delete requests from a server feature to a client
feature
- Fix a crash when incoming subscription requests where missing the
optional `serverFeatureType`
- Improve test cases to consider bindings and subscriptions of multiple
remote devices, which should only get their corresponding bindings and
subscriptions when read

Fixes https://github.com/enbility/spine-go/issues/56

Run Details

545 of 579 new or added lines in 10 files covered. (94.13%)

2 existing lines in 1 file now uncovered.

5258 of 5600 relevant lines covered (93.89%)

99.68 hits per line