Qiskit / qiskit / 13461413826

88%

Build Type

push

github

Committed by web-flow

Commit Message

Bump rustworkx-core and hashbrown to latest releases (#13733)

* Bump rustworkx-core and hashbrown to latest releases

This commit bumps the rustworkx-core and hashbrown dependencies to the
latest releases. We were previously blocked on upgrading hashbrown
because we use it to exchange data with rustworkx-core and
rustworkx-core 0.15.x depended on the previous release of hashbrown. But
with the new release of rustworkx-core 0.16.0 it is using the latest
release of hashbrown and we can bump both at the same time.

One thing we'll want to do is upgrade our ndarray version in the future
because rustworkx-core uses 0.16 now, but we're blocked on that by our
einsum library at the momemnt. Luckily we don't exchange arrays with
rustworkx at the moment in rust. But this will become an issue if we do.

* Use IndexMap for basis translator

The basis translator implementation is sensitive to iteration order in
parts for places HashMaps and HashSets were being used. We used to get
by when hashbrown was using ahash and the iteration was likely
accidently deterministic for the types we were putting in them. However,
this wasn't an API guarantee and likely just a side effect of using u32s
in places. The latest hashbrown version changes the hashing algorithm to
use foldhash which is changing the iteration order. This was causing
test failures. This commit corrects this issue by switching every use of
hashbrown types to indexmap which has a deterministic iteration order.
The only exception is the input types to the run function, which still
uses hashbrown because pyo3 wasn't able to resolve the conversion
trait implementations when switching to indexmap types. This adds the
overhead of a copy, but this is a small price to pay for fixing the
iteration issue determinism.

* Add missing ahash usage on one indexmap

Run Details

114 of 118 new or added lines in 5 files covered. (96.61%)

5 existing lines in 3 files now uncovered.

78399 of 88970 relevant lines covered (88.12%)

349811.21 hits per line