safe-global / safe-client-gateway / 13458779067

89%

Build Type

push

github

Committed by web-flow

Commit Message

refactor: issue token from validated message (#2351)

We have to methods for Sign-In with Ethereum messages. This refactors the existing to use the simpler method implemented for org. onboard.

The `ISiweRepository` is now only responsible for parsing and validating a submitted `message`/`signature`. The `nonce` of which is compared against cached ones. As the upper limit for token expiration is auth-specific, that is now handled in the `AuthService`.

1. User calls `/nonce` and one is generated, cached and returned to the user.
2. User calls `/verify` and the message is parsed, validated, nonce compared, signature verified and then passed to the `AuthService`. The service ensures an `expirationTime` does not exceed the maxium and issues the token.

Note: on-chain signature verification was removed as it is not being used.

- Remove unused code from `ISiweRepository`.
- Move `expirationTime` check to `AuthService`.
- Add `iat` claim to token.
- Update tests accordingly.

Run Details

3008 of 3624 branches covered (83.0%)

Branch coverage included in aggregate %.

11 of 11 new or added lines in 2 files covered. (100.0%)

1 existing line in 1 file now uncovered.

10397 of 11085 relevant lines covered (93.79%)

508.68 hits per line