safe-global / safe-client-gateway / 13453624767

89%

Build Type

push

github

Committed by web-flow

Commit Message

feat: only allow adding wallets with signature (#2345)

This modifies the current endpoint for adding a `Wallet` to a `User` to expect a SiWe `message` and `signature`, which must pass validation in order to succeed.

The `POST` `/v1/wallet/:walletAddress` endpoint now becomes `/v1/wallet/add`, which requires the original access token cookie, as well as the following request:

```ts
type Request = {
  message: string;
  signature: `0x${string}`
}
```

The `message` is parsed according to EIP-4362 (Sign-In with Ethereum) and the `signature` validated accordingly. The recovered address is that which a `Wallet` is created for.

As with other endpoints, the access token cookie is responsible for finding the `User` - the `address` of the token:

- Rename `POST` `/v1/wallet/:walletAddress` to `/v1/wallet/add`, and expect/validate payload
- Add `SiweMessageSchema`, responsible for parsing a string `message` to an object
- Add `ISiweRepository['getValidatedSiweMessage']`, responsible for returning a parsed/validated string `message` as an object
- Add/update tests accordingly

Run Details

3016 of 3633 branches covered (83.02%)

Branch coverage included in aggregate %.

31 of 32 new or added lines in 5 files covered. (96.88%)

1 existing line in 1 file now uncovered.

10419 of 11111 relevant lines covered (93.77%)

507.35 hits per line