lightninglabs / taproot-assets / 13448911508

54%

main: 47%

Build Type

Pull #1386

github

Committed by Roasbeef

Commit Message

tapdb: expand allowed proof types in universe-related tables

This commit introduces a migration that expands the allowed values for
the "proof_type" column in the universe-related tables by adding new
proof types: "burn" and "ignore".

Key changes include:
- Creation of a new table `proof_types` to store valid proof type
  values. Before this commit, we used a `CHECK` statement. With the way
  sqlite works, we can't _alter_ the `CHECK` statement, and just
  dropping the row would lose data.

  So instead, we add a new enum-like table instead. This can be updated
  in future migrations to add new proof types. We then do a migration to
  update all tables to use this instead.

- Updates to the `universe_roots`, `federation_global_sync_config`, and
  `federation_uni_sync_config` tables to accommodate the new proof
  types. This involves adding a new column `proof_type_ext` that
  references the `proof_types` table, copying existing data, and
  renaming columns to maintain the original structure.

- A new test case `TestMigration29` has been added to ensure the
  migration works as expected, verifying both the migration of existing
  data and the insertion of new rows with the new proof types.

- The `.gitignore` file has been updated to exclude files matching the
  pattern `.aider*`.

Additionally, a down migration script has been created to revert these
changes if necessary. This ensures that the database schema can be
rolled back to its previous state without data loss.

Pull Request Pull Request #1386: tapdb: expand allowed proof types in universe-related tables

Run Details

18 of 21 new or added lines in 5 files covered. (85.71%)

31 existing lines in 11 files now uncovered.

48623 of 89338 relevant lines covered (54.43%)

0.8 hits per line