Stellarium / stellarium / 13435660171

12%

master: 12%

Pull #4145

github

Use commonNameMap instead of iterating over dsoArray

The search() function is used when loading DSO outlines and discovery
information. Its search for English names actually doesn't work, because
it's called before any sky culture is loaded, which is when Nebula's
English name is set. This doesn't appear to be a problem, because all
the data we have are properly handled by a search by designation.

Now it's renamed to searchForCommonName(), and it uses commonNameMap
instead of iterating over all the array of ~95k DSOs. This makes loading
of outlines and discovery information almost instant, while before this
patch it took about half a second to a second for each.

A small change in functionality is that now all the common names are
searched, not only the first one per DSO, but it seems to be a useful
change.

0 of 5 new or added lines in 1 file covered. (0.0%)

14615 of 120977 relevant lines covered (12.08%)

17639.95 hits per line