• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In
Warning: This build has drifted.
The coverage report for this pull request build may be inaccurate because its base commit is no longer the HEAD of its target branch.
This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

    • Learn more: For more information on this, see Tracking coverage changes for pull request builds.
    • Fix now: For a quick fix, rebase this PR at GitHub. Your next report should be accurate.
    • Prevent going forward: To avoid this issue with future PRs, see these Recommended CI Configurations.
New Repo Setting:
INCLUDE COVERAGE % WITH WARNINGS ABOUT DRIFTED BUILDS?

Enabling this setting will include a (potentially inaccurate) coverage % with warning messages in status updates for drifted builds.

Adjust setting

lightninglabs / taproot-assets / 13426103383
54%
main: 57%

Build:
Build:
LAST BUILD BRANCH: gh-readonly-queue/main/pr-1913-46bebd3a34518c96f58957c2cb9c91e18cfdf1cf
DEFAULT BRANCH: main
Ran 20 Feb 2025 01:48AM UTC
Jobs 2
Files 252
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

20 Feb 2025 01:45AM UTC coverage: 54.392% (-0.02%) from 54.41%
13426103383

Pull #1386

github

Roasbeef
tapdb: expand allowed proof types in universe-related tables

This commit introduces a migration that expands the allowed values for
the "proof_type" column in the universe-related tables by adding new
proof types: "burn" and "ignore".

Key changes include:
- Creation of a new table `proof_types` to store valid proof type
  values. Before this commit, we used a `CHECK` statement. With the way
  sqlite works, we can't _alter_ the `CHECK` statement, and just
  dropping the row would lose data.

  So instead, we add a new enum-like table instead. This can be updated
  in future migrations to add new proof types. We then do a migration to
  update all tables to use this instead.

- Updates to the `universe_roots`, `federation_global_sync_config`, and
  `federation_uni_sync_config` tables to accommodate the new proof
  types. This involves adding a new column `proof_type_ext` that
  references the `proof_types` table, copying existing data, and
  renaming columns to maintain the original structure.

- A new test case `TestMigration29` has been added to ensure the
  migration works as expected, verifying both the migration of existing
  data and the insertion of new rows with the new proof types.

- The `.gitignore` file has been updated to exclude files matching the
  pattern `.aider*`.

Additionally, a down migration script has been created to revert these
changes if necessary. This ensures that the database schema can be
rolled back to its previous state without data loss.
Pull Request #1386: tapdb: expand allowed proof types in universe-related tables

11 of 12 new or added lines in 5 files covered. (91.67%)

47 existing lines in 12 files now uncovered.

48595 of 89342 relevant lines covered (54.39%)

0.8 hits per line

New Missed Lines in Diff

Lines Coverage ∆ File
1
75.26
0.0% tapdb/universe_stats.go

Uncovered Existing Lines

Lines Coverage ∆ File
1
85.0
-0.23% commitment/tap.go
2
62.07
-6.9% fn/iter.go
2
83.27
-0.76% mssmt/compacted_tree.go
2
88.64
-0.91% tapdb/mssmt.go
2
52.98
-1.32% tapdb/sqlc/mssmt.sql.go
2
76.0
-1.33% universe_rpc_diff.go
3
43.43
0.35% tapchannel/aux_leaf_signer.go
4
81.76
-0.68% tapdb/universe.go
4
77.52
0.38% tapgarden/caretaker.go
5
85.68
-1.19% universe/syncer.go
6
63.65
-0.1% rpcserver.go
14
89.54
-7.84% address/mock.go
Jobs
ID Job ID Ran Files Coverage
1 itest - 13426103383.1 20 Feb 2025 01:56AM UTC 247
47.43
GitHub Action Run
2 unit - 13426103383.2 20 Feb 2025 01:48AM UTC 252
27.53
GitHub Action Run
Source Files on build 13426103383
  • Tree
  • List 252
  • Changed 18
  • Source Changed 0
  • Coverage Changed 18
Coverage ∆ File Lines Relevant Covered Missed Hits/Line
  • Back to Repo
  • Pull Request #1386
  • PR Base - main (#13424954486)
  • Delete
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2025 Coveralls, Inc