MITLibraries / dspace-submission-composer / 13422831257

96%

Build Type

push

github

Committed by web-flow

Commit Message

Improve logging for 'submit' and 'finalize' methods (#144)

Why these changes are being introduced:
* Improve the logging of the DSC application for the submit and finalize CLI commands to ensure clear, detailed messages are logged that can help with debugging.

How this addresses that need:
* Update Config to support 'WARNING_ONLY_LOGGERS' env var
* Replace SQSClient.process_result_message with SQSClient.parse_dss_result_message
* Update Workflow.submit_items to return a list of successfully submitted
items (i.e., item submission messages sent to DSS), denoting item identifier
and message ID
* Rework try-except blocks to provide more granular error handling
* Rename Workflow.process_results -> Workflow.process_ingest_results
* Update unit tests as needed

Side effects of this change:
* Change to remove logging of the full DSS result message during 'finalize' methods will require users to either inspect the DSS CloudWatch logs or look at the result message in SQS. This decision was made to avoid the logging of full the `ExceptionTraceback` for failing ingests.

Relevant ticket(s):
* https://mitlibraries.atlassian.net/browse/IN-1172

Run Details

77 of 89 new or added lines in 4 files covered. (86.52%)

1 existing line in 1 file now uncovered.

636 of 675 relevant lines covered (94.22%)

0.94 hits per line