rust-bitcoin / rust-bitcoin / 13416421079
83%

DEFAULT BRANCH: master
Ran
Jobs 1
Files 123
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 82.73% (-0.04%) from 82.768%
13416421079

push

github

apoelstra 
Merge rust-bitcoin/rust-bitcoin#4047: Properly deprecate `Hash::from_slice`

<a class=hub.com/rust-bitcoin/rust-bitcoin/commit/f61e93ccf1db7e7e3c9604fdb09b4e25195d88b2">f61e93ccf<a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/f71e28eea22cee694d52242693492fe90b3923c9"> Properly deprecate Hash::from_slice (Tobin C. Harding)
<a class="double-link" href="https://github.com/rust-bitcoin/rust-bitcoin/commit/50c0af7138bc90b621c6dd079de9c4c34d26c462">50c0af713</a> Stop using Hash::from_slice (Tobin C. Harding)

Pull request description:

  The `hashes::error::FromSliceError` error is only returned from `from_slice`. We attempted to deprecate this function but it seems we only did half a job at it.

  - deprecate _all_ instances of the method/function
  - deprecate the error type
  - stop using the deprecated functions in `bitcoin`

  Close: #4053

ACKs for top commit:
  apoelstra:
    ACK f61e93ccf1db7e7e3c9604fdb09b4e25195d88b2; successfully ran local tests

Tree-SHA512: 61a0e5127b1e90812794ca1cd68e85498ad

5 of 11 new or added lines in 8 files covered. (45.45%)

8 existing lines in 1 file now uncovered.

21178 of 25599 relevant lines covered (82.73%)

17067.0 hits per line

Uncovered Changes

Lines Coverage ∆ File
3
88.6
 -0.93% hashes/src/hmac/mod.rs
2
52.78
 0.0% hashes/src/sha256t/mod.rs
1
39.71
 -11.76% hashes/src/internal_macros.rs

Coverage Regressions

Lines Coverage ∆ File
8
39.71
 -11.76% hashes/src/internal_macros.rs
Jobs
ID Job ID Ran Files Coverage
1 13416421079.1 123
82.73
 GitHub Action Run
Source Files on build 13416421079