openconfig / goyang / 13402739519

78%

push

github

Fix an age-old bug with `FromFloat` handling of negatives. (#268)

* Fix an age-old bug with `FromFloat` handling of negatives.

 * (M) pkg/yang/types_builtin(_test)?.go
    - This change squashes a bug that has existed for a long time
      in `FromFloat`, but only shows up on arm64. I finally have an
      arm64 machine and so found the issue. It was originally reported
      in https://github.com/openconfig/ygot/issues/766. The issue is
      that uint64 of a negative float64 is undefined  -- and on arm64
      on darwin returns 0, which made some test cases fail only on this
      architecture.

* Add missing comment.

* `gofmt`

2 of 2 new or added lines in 1 file covered. (100.0%)

3061 of 3932 relevant lines covered (77.85%)

0.91 hits per line