urwid / urwid / 13388670106

74%

push

travis-pro

Make sizing computation much faster for nested containers (#991)

When nesting Columns, Pile and other containers, calls to widget.sizing() can
become very slow, especially on slower architectures. Profiling showed that we
are spending a big slice of time in enum.IntFlag dunder methods (i.e, __new__,
__or__, __and__ and __call__) and _get_value (which is used by dunder methods).

   111191    0.014    0.000    0.014    0.000 enum.py:1129(__new__)
   333573    0.039    0.000    0.053    0.000 enum.py:1544(_get_value)
    56592    0.040    0.000    0.086    0.000 enum.py:1551(__or__)
    54599    0.037    0.000    0.080    0.000 enum.py:1562(__and__)
   111191    0.021    0.000    0.035    0.000 enum.py:726(__call__)

Although enum.IntFlag feels much cleaner than enum.IntEnum for the job, the
performance of enum.IntEnum is much better.

In Subiquity, switching from enum.IntFlag to enum.IntEnum causes calls to
Pile.sizing() to be about 10 times faster.

Signed-off-by: Olivier Gayot <olivier.gayot@canonical.com>

1941 of 2548 branches covered (76.18%)

Branch coverage included in aggregate %.

20 of 20 new or added lines in 2 files covered. (100.0%)

9264 of 12436 relevant lines covered (74.49%)

6.22 hits per line