• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

neo-project / neo / 13367917725
79%

Build:
DEFAULT BRANCH: master
Ran 17 Feb 2025 10:21AM UTC
Jobs 1
Files 411
Run time 2min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

17 Feb 2025 10:17AM UTC coverage: 78.319% (+0.1%) from 78.212%
13367917725

push

github

web-flow
Improve MaxNestingDepth of WitnessCondition (#3761)

* tests: add UT for nested WitnessCondition

This just works as the code works.

Signed-off-by: Roman Khimov <roman@nspcc.ru>

* WitnessCondition: unify nesting checks, fix MaxNestingDepth

1. We have some duplication around "maxNestDepth <= 0" checks.
2. If we're to fix them by moving to DeserializeFrom() and thereby affecting
   all types of conditions we can discover a simple truth about conditions
   that was hidden previously: our real supported MaxNestingDepth is 3, not 2.
3. Test_WitnessCondition_Nesting works as before, check it there, we have
   And->And->Boolean and other nesting cases, 3-4 elements in the chain,
   not 2.

Signed-off-by: Roman Khimov <roman@nspcc.ru>

* WitnessCondition: unify JSON parsing as well

Signed-off-by: Roman Khimov <roman@nspcc.ru>

* tests: s/WitnessContition/WitnessCondition/

Fix typo.

Signed-off-by: Roman Khimov <roman@nspcc.ru>

* Format header

* Format arrays in UT_WitnessCondition.cs

---------

Signed-off-by: Roman Khimov <roman@nspcc.ru>
Co-authored-by: Shargon <shargon@gmail.com>
Co-authored-by: Christopher Schuchardt <cschuchardt88@gmail.com>
Co-authored-by: NGD Admin <154295625+NGDAdmin@users.noreply.github.com>

6006 of 8736 branches covered (68.75%)

Branch coverage included in aggregate %.

5 of 5 new or added lines in 3 files covered. (100.0%)

11 existing lines in 2 files now uncovered.

21990 of 27010 relevant lines covered (81.41%)

128887.44 hits per line

Uncovered Existing Lines

Lines Coverage ∆ File
4
20.24
-1.88% src/Neo/Network/P2P/TaskManager.cs
7
82.12
-1.55% src/Plugins/RpcServer/RpcServer.Wallet.cs
Jobs
ID Job ID Ran Files Coverage
1 13367917725.1 17 Feb 2025 10:21AM UTC 2660
25.17
GitHub Action Run
Source Files on build 13367917725
  • Tree
  • List 411
  • Changed 319
  • Source Changed 4
  • Coverage Changed 319
Coverage ∆ File Lines Relevant Covered Missed Hits/Line Branch Hits Branch Misses
  • Back to Repo
  • Github Actions Build #13367917725
  • 582556a6 on github
  • Prev Build on master (#13361557427)
  • Next Build on master (#13373537291)
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2025 Coveralls, Inc