babelfish-for-postgresql / babelfish_extensions / 13364607663

77%

Build Type

push

github

Committed by web-flow

Commit Message

Support PostGIS Functions: STDimension, STDisjoint, STIntersects, STIsClosed, STIsEmpty, STIsValid for Geospatial datatypes (#3458)

Implemented several GeoSpatial SQL functions that were previously unsupported in Babelfish. The following functions have been added:

1. STDimension
2. STDisjoint
3. STIntersects
4. STIsClosed
5. STIsEmpty
6. STIsValid

Changes include:

1. Function Implementations:

    * Implemented each function by utilizing PostGIS functions where appropriate, with necessary adjustments to ensure 
    compatibility.

2. Parser Updates:

    * Added function definitions to the SQL parser to recognize these new functions.
    * Ensured proper syntax handling for each function, including parameter types and return values.

3. Test Cases:

    * Created comprehensive test cases for each function, covering various scenarios 

4. Error Handling:

    * Implemented appropriate error handling 
    
4. Extending existing functionalities:

    * Added support for empty instances in geography datatypes
    * Fixed binary string handling for dump and restore tests

Co-authored-by: Mohit Raj <mrxmohit@amazon.com>

Run Details

4 of 4 new or added lines in 1 file covered. (100.0%)

2 existing lines in 1 file now uncovered.

47128 of 62827 relevant lines covered (75.01%)

184775.25 hits per line