kubevirt / hyperconverged-cluster-operator / 13357330062
76%

DEFAULT BRANCH: main
Ran
Jobs 1
Files 79
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 72.318% (+0.4%) from 71.935%
13357330062

push

github

web-flow 
Allow customizing the CLI download link (#3281)

* remove cmdcommon.stringinslice in favor of slices.Contains from the standard library

Signed-off-by: Nahshon Unna-Tsameret <nunnatsa@redhat.com>

* simplfy hcoutil.GetOperatorNamespaceFromEnv()

stop returning error from this function. Only check that the
OPERATOR_NAMESPACE environment variable is populated on boot. then don't
check it anymore, to save many redundant error handlings.

Signed-off-by: Nahshon Unna-Tsameret <nunnatsa@redhat.com>

* Stop recalculate namespaced names

The current code re-calculates the expected namespaced name to resolve
reconcile request. But the calculation is based on data that is never
changed.

This commit moves all the reconcile request resolving logic to a
seperate package, for better readability and maintenance. The namespaced
names are only calulated once, at boot time.

Signed-off-by: Nahshon Unna-Tsameret <nunnatsa@redhat.com>

* add new request type for Ingress

Signed-off-by: Nahshon Unna-Tsameret <nunnatsa@redhat.com>

* Add the new pkg/domainname package

This package is a goroutine-safe storage of the CLI download host name,
to be shared between multiple controller.

Signed-off-by: Nahshon Unna-Tsameret <nunnatsa@redhat.com>

* Add new controller to watch the cluster ingress

The controller updates the ingress status with the virt-download new
component, to allow the user to customize the CLI download URLs.

If the cli download host is customized (or stop been customized) the
controller triggers an event in the hyperconverged controller to force
it to update the download URLs.

Signed-off-by: Nahshon Unna-Tsameret <nunnatsa@redhat.com>

* Add new request type

The controller can now been trigger by the ingress controller
notifications.

Signed-off-by: Nahshon Unna-Tsameret <nunnatsa@redhat.com>

* Register the new ingress cluster controller

Also, creates a new event channel, and give it to the hyperconverged
controller (the reader) and the ingress clustr c... (continued)

305 of 405 new or added lines in 12 files covered. (75.31%)

3 existing lines in 2 files now uncovered.

6364 of 8800 relevant lines covered (72.32%)

0.8 hits per line

New Missed Lines in Diff

Lines Coverage ∆ File
1
93.55
 0.0% controllers/operands/kubevirtConsolePlugin.go
14
51.72
 controllers/ingresscluster/tls.go
17
3.11
 -0.03% pkg/components/components.go
21
82.21
 0.46% controllers/hyperconverged/hyperconverged_controller.go
47
76.96
 controllers/ingresscluster/ingress-cluster-controller.go

Uncovered Existing Lines

Lines Coverage ∆ File
1
82.14
 -1.19% controllers/operands/quickStart.go
2
82.21
 0.46% controllers/hyperconverged/hyperconverged_controller.go
Jobs
ID Job ID Ran Files Coverage
1 13357330062.1 79
72.32
 GitHub Action Run
Source Files on build 13357330062