skeema / skeema / 13337809543

92%

push

github

chore: fixes for new Go 1.24 `go vet` printf analyzer

In Go 1.24, `go vet` now complains about calls to printf-style functions where
the format arg is a non-constant string. Some of these were legitimate
mistakes where print is better than printf, but most were not; our call
pattern for associating an exit code with an error had to be refactored to
satisfy this `go vet` change.

Since Skeema's go.mod always specifies the older of the 2 currently-supported
Go releases, these call sites wouldn't have a problem until ~6 months from now
when go.mod starts specifying 1.24 instead of 1.23. However, these are being
fixed now proactively, to avoid unnecessary disruption in the future.

24 of 27 new or added lines in 9 files covered. (88.89%)

10256 of 10997 relevant lines covered (93.26%)

1.11 hits per line