rust-bitcoin / rust-bitcoin / 13334719205

83%

push

github

Merge rust-bitcoin/rust-bitcoin#4050: Validate compressed WIF keys

<a class=hub.com/rust-bitcoin/rust-bitcoin/commit/<a class="double-link" href="https://git"><a class=hub.com/rust-bitcoin/rust-bitcoin/commit/<a class="double-link" href="https://git"><a class=hub.com/rust-bitcoin/rust-bitcoin/commit/00cd247bc49451fe8c2cbf537ed042b0bb5c3340">00cd247bc Validate compressed WIF keys (ndungudedan)

Pull request description:

  For private WIF keys corresponding to a compressed address, the last byte of the key needs to be 0x01, but the API doesn't enforce this when using PrivateKey::from_wif(). So, invalid keys can be accepted.

  Thus we check if the last byte is equivalent to 0x01 if the key's length is 34 (which indicates it's
  compressed).

  resolves #3773

ACKs for top commit:
  Kixunil:
    ACK 00cd247bc49451fe8c2cbf537ed042b0bb5c3340
  tcharding:
    ACK 00cd247bc49451fe8c2cbf537ed042b0bb5c3340
  apoelstra:
    ACK 00cd247bc49451fe8c2cbf537ed042b0bb5c3340; successfully ran local tests

Tree-SHA512: 8d2cfc13f5f4f902cde220106857aac2167

11 of 18 new or added lines in 1 file covered. (61.11%)

20956 of 25334 relevant lines covered (82.72%)

17228.03 hits per line