delvtech / hyperdrive / 13322535947

87%

main: 87%

push

github

Matching Engine V2 new PR on top of the part 1 PR#1225 with already approved code (#1239)

* sync with main again

* Finished _handleMint logic

* changed code layout to avoid stack too deep

* reduced some unnecessary local vars

* Applied the DELV Solidity Code Styling

* Finished _handleBurn and applied DELV Solidity Code Styling

* Bug fix: output should go to the specified destination instead of the trader's address

* remove some redundancy

* Added unit tests -- WIP, some tests violated some assertions, to be solved

* minor fix -- DELV solidity code styling

* recover the missing file .env_template

* Fixed failing unit test of _handleBurn, reason: super bad pricing leading to revert

* Fixed failing test - the Hyperdrive instance reverted without a customized error code

* Fixed failing test -- enforce revert by using unreasonably high min vault share price

* Fixed all failing tests for _handleMint and _handleBurn situations

* Bug fix -- common minVaultSharePrice should take the max of the two, not the min

* Removed unused error codes in the interface

* Enriched OrdersMatched event and removed other two unnecessary events

* Fixed orderIntent TYPEHASH per Alex's comments

* Updated the HyperdriveMatchingEngineV2Test wrt comments per the DELV solidity code styling

* Updated the HyperdriveMatchingEngineV2 wrt comments per the DELV solidity code styling

* Minor code changes to resolve review comments

* Logic update -- dynamic pricing

* Update: support both baseToken and vaultShareToken as the fund token

* Finished the transfer of long positions

* Finished _handleTransfer, compressed Case 3 and 4 together

* Combining two mappings into one with stuct of 2 uint128 elements

* Make Code Pretty Again

* Finished single order validation used for fillOrder function

* Temporary progress commit -- fillOrder

* Code optimization -- finally getting rid of some stack cycling needed

* Code optimization -- removing more stack cycling vars

* Temp... (continued)

196 of 334 new or added lines in 1 file covered. (58.68%)

3233 of 3737 relevant lines covered (86.51%)

296149.14 hits per line