MITLibraries / transmogrifier / 13295541864

99%

main: 99%

Pull #244

github

Update logging, no filtering, explicit warning

Why these changes are being introduced:

The previous approach filtered all logging to only loggers
from the namespace 'transmogrifier' thereby excluding the
new 'timdex_dataset_api' (TDA) logging that we would like
exposed.  This pattern works well most of the time when
3rd party library logging is not needed, but inflexible
when it is.

How this addresses that need:

Reworks the application logging setup as part of
configure_logger() to:

* not use logging.basicConfig()
* avoid filtering loggers, but instead explicitly setting
some logger names to WARNING level (e.g. chatty ones
like botocore) via arguments or env vars

Side effects of this change:

In production, where log level is INFO, it is possible
that some libraries may produce more logging statements,
but anticipated to be low. But desirable logs, like the
timdex_dataset_api library, will now show and will be
driven by this application's --verbose flag.

Relevant ticket(s):
* https://mitlibraries.atlassian.net/browse/TIMX-459

9 of 11 new or added lines in 2 files covered. (81.82%)

1763 of 1787 relevant lines covered (98.66%)

0.99 hits per line