rust-bitcoin / rust-bitcoin / 13271357574

83%

Build Type

push

github

Committed by apoelstra

Commit Message

Merge rust-bitcoin/rust-bitcoin#3961: Invert dependency between `io` and `hashes`

<a class=hub.com/rust-bitcoin/rust-bitcoin/commit/<a class="double-link" href="https://git"><a class=hub.com/rust-bitcoin/rust-bitcoin/commit/fd4586eaae22cafb5a04cdc55919a4ec4aa6151a">fd4586eaa<a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/2c4e7964a085e2841e4f8f67b36bfffd473678b2"> Invert dependency between io and hashes (Tobin C. Harding)
<a class="double-link" href="https://github.com/rust-bitcoin/rust-bitcoin/commit/9833ca32ce6948069fff92846022cdbd0f91b7dd">9833ca32c</a> primitives: Do not depend on bitcoin_io (Tobin C. Harding)

Pull request description:

  Currently in order to release `hashes v1.0` we need to 1.0 `io` as well. For multiple reasons, many out of our control, the `io` crate may not stabalise any time soon.

  Instead we can invert the dependency between the two crates.

   This is an ingenious idea, props to Kixunil for coming up with it.

  Notes

  - This work highlights that we cannot call `hash_reader` on a siphash.
  - We cannot implement `Hmac::hash_reader` without silently ignoring the key - this would be a footgun
  - This work also highlights that our current `hash_reader` code is not well tested.

ACKs for top commit:
  Kixunil:
    ACK fd4586eaae22cafb5a04cdc55919a4ec4aa6151a
  apoelstra:
    ACK fd4586eaae22cafb5a04cdc55919a4ec4aa6151a; successfully ran local tests

Tree-SHA512: b3fbaf8006129b6e89955bad3ff32e37544

Coverage Stats

145 of 159 new or added lines in 1 file covered. (91.19%)

12 existing lines in 3 files now uncovered.

20844 of 25231 relevant lines covered (82.61%)

17310.81 hits per line