tarantool / luajit / 13256673290

93%

tarantool/master: 93%

Build Type

push

github

Committed by Buristan

Commit Message

Fix recording of BC_VARG.

Reported by Bachir Bendrissou.

(cherry picked from commit 62e362afb)

When the trace is started after the stitching, it may not have some
slots from the first one. That slot may be the first slot given to the
`select()` function (if it is determined by the call that caused the
stitch). Before the patch, there is no loading of this slot in the
`rec_varg()` for the trace, and the 0 value from slots is taken instead.
Hence, the following recording of `BC_VARG` is incorrect.

This patch fixes this by using the `getslot()` instead of taking the
value directly.

Sergey Kaplun:
* added the description and the test for the problem

Part of tarantool/tarantool#11055

Reviewed-by: Sergey Bronnikov <sergeyb@tarantool.org>
Signed-off-by: Sergey Kaplun <skaplun@tarantool.org>
(cherry picked from commit 2ce227aa9)

Run Details

5698 of 6036 branches covered (94.4%)

Branch coverage included in aggregate %.

1 of 1 new or added line in 1 file covered. (100.0%)

8 existing lines in 5 files now uncovered.

21705 of 23442 relevant lines covered (92.59%)

2964283.68 hits per line