• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

zooniverse / front-end-monorepo / 13252430262
77%

Build:
DEFAULT BRANCH: master
Ran 10 Feb 2025 11:25PM UTC
Jobs 1
Files 1436
Run time 177min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

10 Feb 2025 11:21PM UTC coverage: 75.594% (+1.5%) from 74.088%
13252430262

push

github

web-flow
refactor(classifier): use native browser SVG scaling for drawing tools (#6066)

* refactor: use native browser SVG scaling for drawing tools

- remove manual scaling code from `strokeWidth` for all the SVG drawing marks. To be honest, it has never worked very well.
- add `vector-effect="non-scaling-stroke"` to all the SVG drawing marks. This will make the displayed stroke width independent of the scaling of the SVG element, at all zoom levels.
- style marks with `:focus-visible` so that the focus ring is only shown for keyboard interactions.

* Update transcription and freehand Lines

- Use SVG presentation attributes for line styles.
- Specify a stroke width of 2px.

* Update packages/lib-classifier/src/plugins/drawingTools/experimental/components/FreehandLine/FreehandLine.js

Co-authored-by: Delilah C. <23665803+goplayoutside3@users.noreply.github.com>

* Update Mark

- remove redundant `scale` prop.
- adjust stroke width.

* Style freehand lines with CSS

* Use medium outlines for focus rings

* Bump the default mark stroke widths to 3/6px

* Style drawn marks with CSS

* Add non-scaling-stroke to Circle and Rectangle elements

* Remove scale from guides and crosshairSpace

* Fix Circle delete button position per zoom

---------

Co-authored-by: Delilah C. <23665803+goplayoutside3@users.noreply.github.com>
Co-authored-by: Mark Bouslog <mcbouslog@gmail.com>
Co-authored-by: Mark Bouslog <mark@zooniverse.org>

10802 of 16462 branches covered (65.62%)

Branch coverage included in aggregate %.

12 of 14 new or added lines in 8 files covered. (85.71%)

10 existing lines in 4 files now uncovered.

16910 of 20197 relevant lines covered (83.73%)

396.84 hits per line

New Missed Lines in Diff

Lines Coverage ∆ File
2
51.43
0.0% packages/lib-classifier/src/plugins/drawingTools/models/marks/Circle/Circle.js

Uncovered Existing Lines

Lines Coverage ∆ File
1
89.09
-3.64% packages/lib-react-components/src/Media/components/Text/Text.js
1
51.43
0.0% packages/lib-classifier/src/plugins/drawingTools/models/marks/Circle/Circle.js
4
54.11
-3.03% packages/lib-classifier/src/components/Classifier/components/SubjectViewer/components/ScatterPlotViewer/components/ScatterPlot/components/Selections/Selections.js
4
66.67
-7.84% packages/lib-classifier/src/components/Classifier/components/SubjectViewer/components/ScatterPlotViewer/components/ScatterPlot/components/Selections/DeleteButton.js
Subprojects
ID Flag name Job ID Ran Files Coverage
1 /jobs/160141857 13252430262.1 10 Feb 2025 11:25PM UTC 1436
75.59
GitHub Action Run
Source Files on build 13252430262
  • Tree
  • List 1436
  • Changed 66
  • Source Changed 14
  • Coverage Changed 15
Coverage ∆ File Lines Relevant Covered Missed Hits/Line Branch Hits Branch Misses
  • Back to Repo
  • Github Actions Build #13252430262
  • 3d3aefcc on github
  • Prev Build on master (#13167827190)
  • Next Build on master (#13269237664)
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc