13240728753
59%
master: 65%

Ran 10 Feb 2025 12:42PM UTC

Jobs 3

Files 825

Run time 2min

Badge

Embed ▾

Committed 10 Feb 2025 12:21PM UTC coverage: 49.33% (+0.02%) from 49.311%

Build # 13240728753

Build Type

Pull #9478

github

Committed by

ellemouton

Commit Message

graph+discovery: move funding tx validation to gossiper

This commit is a pure refactor. We move the transaction validation
(existence, spentness, correctness) from the `graph.Builder` to the
gossiper since this is where all protocol level checks should happen.
All tests involved are also updated/moved.

Pull Request Pull Request #9478: discovery+graph: move funding tx validation to the gossiper

Run Details

126 of 236 new or added lines in 2 files covered. (53.39%)

23 existing lines in 8 files now uncovered.

100815 of 204369 relevant lines covered (49.33%)

1.54 hits per line

New Missed Lines in Diff

Lines	Coverage	∆	File
8	59.96	0.64%	graph/builder.go
102	69.44	-1.83%	discovery/gossiper.go

Uncovered Existing Lines

Lines	Coverage	∆	File
1	63.89	-0.04%	server.go
2	90.22	-2.17%	input/taproot.go
2	82.91	-0.32%	rpcperms/interceptor.go
2	74.65	0.16%	htlcswitch/switch.go
2	69.44	-1.83%	discovery/gossiper.go
3	74.14	1.29%	chainntnfs/btcdnotify/btcd.go
5	81.33	-0.42%	chainntnfs/txnotifier.go
6	59.96	0.64%	graph/builder.go

Jobs

ID	Job ID	Ran	Files	Coverage
1	itest-neutrino - 13240728753.1	10 Feb 2025 12:47PM UTC	825	47.89	GitHub Action Run
2	itest-btcd - 13240728753.2	10 Feb 2025 12:42PM UTC	825	48.27	GitHub Action Run
3	itest-bitcoind - 13240728753.3	10 Feb 2025 12:45PM UTC	825	48.31	GitHub Action Run

lightningnetwork / lnd / 13240728753
59%
master: 65%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

New Missed Lines in Diff

Uncovered Existing Lines

Jobs

Source Files on build 13240728753

lightningnetwork / lnd / 13240728753 59% master: 65%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

New Missed Lines in Diff

Uncovered Existing Lines

Jobs

Source Files on build 13240728753

lightningnetwork / lnd / 13240728753
59%
master: 65%

README BADGES
x