rust-bitcoin / rust-bitcoin / 13229157023

83%

Build Type

push

github

Committed by apoelstra

Commit Message

Merge rust-bitcoin/rust-bitcoin#4010: Add a tagged hash engine

<a class=hub.com/rust-bitcoin/rust-bitcoin/commit/<a class="double-link" href="https://git"><a class=hub.com/rust-bitcoin/rust-bitcoin/commit/6002ccdc567b26c69f6b55173f5d11b95b4d6966">6002ccdc5<a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/329aaf452bde52f70171c30abc1c139591099b9d"> Add a tagged sha256t hash engine (Tobin C. Harding)
<a class="double-link" href="https://github.com/rust-bitcoin/rust-bitcoin/commit/3e8e2e46bf7a2c093b832047aaadacf93d40a4ec">3e8e2e46b</a><a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/329aaf452bde52f70171c30abc1c139591099b9d"> Use Self::Engine in GeneralHash impl (Tobin C. Harding)
</a><a class="double-link" href="https://github.com/rust-bitcoin/rust-bitcoin/commit/a0211906fe265eb848823c8fdbd407a3ea372770">a0211906f</a><a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/329aaf452bde52f70171c30abc1c139591099b9d"> sha256t: Remove standalone from_engine function (Tobin C. Harding)
</a><a class="double-link" href="https://github.com/rust-bitcoin/rust-bitcoin/commit/5ce8781162cdf75515a26ceab4209cd0c89c0001">5ce878116</a><a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/329aaf452bde52f70171c30abc1c139591099b9d"> Remove the Tag::engine method (Tobin C. Harding)
</a><a class="double-link" href="https://github.com/rust-bitcoin/rust-bitcoin/commit/ba6425947fa9b9a4f43c4977cb3b4bf477d4ce1e">ba6425947 hashes: Use associated cost for pre-tagging (Tobin C. Harding)
613fddc82 Delete deprecated sha256t_hash_newtype macro (Tobin C. Harding)

Pull request description:

  Add a new hash engine to the `sha256t` module and put the tag on it.

  Note the issue suggests adding the tag to `sha256::HashEngine` but this PR adds a new type to `sha256t` and adds the tag on it.

  Resolve: #1552

ACKs for top commit:
  apoelstra:
    ACK 6002ccdc567b26c69f6b55173f5d11b95b4d6966; successfully ran local tests
  Kixunil:
    ACK 6002ccdc567b26c69f6b55173f5d11b95b4d6966

Tree-SHA512: 8a8945bdb4a7a3e9192e72143f37b025f5e

Coverage Stats

22 of 24 new or added lines in 3 files covered. (91.67%)

6 existing lines in 1 file now uncovered.

20729 of 25114 relevant lines covered (82.54%)

17415.37 hits per line