payjoin / rust-payjoin / 13203244614

83%

Build Type

push

github

Committed by web-flow

Commit Message

Fix payjoin-cli v1 coverage (#532)

Fix #499 

This required a few changes:

- Add an explicit `llvm-cov` command for running the payjoin-cli v1 e2e
test, as it is not currently covered by `--all-features`.
- Add graceful SIGINT handling to payjoin-cli v1.
- Modify the `sigint` test function to wait until the child process
completely exits, so that the interrupt handlers can actually print to
stdout without panicking (`failed printing to stdout: Broken pipe (os
error 32)`). This issue also affected the payjoin-cli v2 test, so this
fix reduces the noise there as well (see
https://github.com/payjoin/rust-payjoin/issues/499#issuecomment-2613238131).
- Remove unnecessary `tokio::spawn`s in tests which moved `cli.stdout`
out of the main loop, also causing panics like the former in interrupt
handlers.
- The last commit only refactors and extracts shared e2e testing code.

Run Details

14 of 15 new or added lines in 2 files covered. (93.33%)

6 existing lines in 3 files now uncovered.

4020 of 5088 relevant lines covered (79.01%)

904.07 hits per line