13202010479
59%
master: 65%

Ran 07 Feb 2025 03:42PM UTC

Jobs 4

Files 978

Run time 3min

Badge

Embed ▾

Committed 07 Feb 2025 02:38PM UTC coverage: 58.793% (+9.5%) from 49.271%

Build # 13202010479

Build Type

Pull #9478

github

Committed by

ellemouton

Commit Message

graph+discovery: move funding tx validation to gossiper

This commit is a pure refactor. We move the transaction validation
(existence, spentness, correctness) from the `graph.Builder` to the
gossiper since this is where all protocol level checks should happen.
All tests involved are also updated/moved.

Pull Request Pull Request #9478: discovery+graph: move funding tx validation to the gossiper

Run Details

163 of 244 new or added lines in 3 files covered. (66.8%)

18 existing lines in 5 files now uncovered.

136213 of 231682 relevant lines covered (58.79%)

19254.05 hits per line

New Missed Lines in Diff

Lines	Coverage	∆	File
8	76.9	18.46%	graph/builder.go
73	78.6	7.66%	discovery/gossiper.go

Uncovered Existing Lines

Lines	Coverage	∆	File
2	74.55	-0.72%	lnrpc/invoicesrpc/invoices_server.go
2	84.62	-1.54%	graph/notifications.go
3	83.3	6.37%	contractcourt/channel_arbitrator.go
5	76.87	-1.78%	lnrpc/websocket_proxy.go
6	76.9	18.46%	graph/builder.go

Jobs

ID	Job ID	Ran	Files	Coverage
1	itest-btcd - 13202010479.1	07 Feb 2025 03:41PM UTC	826	48.23	GitHub Action Run
2	unit - 13202010479.2	07 Feb 2025 03:42PM UTC	856	57.64	GitHub Action Run
3	itest-bitcoind - 13202010479.3	07 Feb 2025 03:43PM UTC	826	48.3	GitHub Action Run
4	itest-neutrino - 13202010479.4	07 Feb 2025 03:43PM UTC	826	47.87	GitHub Action Run

lightningnetwork / lnd / 13202010479
59%
master: 65%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

New Missed Lines in Diff

Uncovered Existing Lines

Jobs

Source Files on build 13202010479

lightningnetwork / lnd / 13202010479 59% master: 65%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

New Missed Lines in Diff

Uncovered Existing Lines

Jobs

Source Files on build 13202010479

lightningnetwork / lnd / 13202010479
59%
master: 65%

README BADGES
x