Qiskit / qiskit / 13163669616

88%

Build Type

push

github

Committed by web-flow

Commit Message

Port standard instructions to Rust. (#13486)

* Extend PackedOperation for standard instructions.

* WIP

* Compiling.

* Add missing module registration.

* Implement Operation::directive

* Add StandardInstructionType enum.

* Expose only StandardInstructionType to Python.

This way, we can also use this enum to tag the Python classes.

* Fix unit access.

* Remove no longer needed enum variant parens.

* Remove unused stuff.

* Fix up packed_instruction docs, add From<StandardInstruction>.

* Fix up imports.

* Improve comments in circuit_instruction.

* Fix typo.

* More doc fixes.

* Reorganize PackedInstruction mem layout to support 32 bit archs.

* Update layout description, cleanup.

* Revert "Update layout description, cleanup."

This reverts commit b6d8f929a.

* Revert "Reorganize PackedInstruction mem layout to support 32 bit archs."

This reverts commit 6049498ba.

* Use bitfield-struct crate for PackedOperation.

Trying out a neat crate for Rust bitfields. The caveats are:

* Custom enums used in the bitfield must specify const funcs for bit
  conversion, and bytemuck's cast functions aren't const.
* The bitfield crate implements Clone for you, but does not seem to have
  a way to disable this. We can't rely on their clone, since for pointer
  types we need to allocate a new Box. To get around this,
  PackedOperation is a wrapper around an internal bitfield struct
  (rather than being a bitfield struct itself).

(Note: I'm not yet happy with this. Specifically, I think the
abstraction may be cleaner if OpBitField is defined entirely in terms of
raw native types and any reinterpretation / transmutation is done from
PackedOperation. Consider this a first pass.)

* Pivot.

* Compiling.

* Remove unused bytemuck stuff.

* Run format.

* Improve static assertion error messages.

* Clean up.

* Implement delay unit for ImmediateValue.

* Finish implementing PointerBits for 32 bit.

I... (continued)

Run Details

392 of 441 new or added lines in 21 files covered. (88.89%)

11 existing lines in 8 files now uncovered.

79237 of 89371 relevant lines covered (88.66%)

350926.62 hits per line