xlnt-community / xlnt / 67853142-21b5-4e24-946e-3f0c93e251de

84%

Build Type

push

circleci

Committed by web-flow

Commit Message

Add support for C++20 and C++23, and experimental support for C++26 (#55)

Changes made by this PR:

1. Support `char8_t` and `std::u8string(_view)` in user-facing code to
support `u8""` string literals in C++20 and newer.
2. Remove `std::aligned_storage` from `xlnt::optional` due to C++23
deprecation warnings.
3. Add experimental support for C++26 - no further changes were
necessary (not yet, at least). I think we can use this to test new C++
compiler versions, but I would not guarantee C++26 support until it is
officially released.
4. Set CI to use C++23. I think it's better to not use C++26 yet to
avoid issues when new compiler versions are released.
5. Fix Unicode file paths on Windows when checking for existence of
files and folders, and when reading a file into a string.


Note: instead of using `const std::u8string &` like we do with
`std::string` in our current code, I chose to use `std::u8string_view`
to avoid unnecessarily copying strings, as we currently do in many cases
(which we cannot properly avoid except when using C strings (bad idea
IMO) or by switching to C++17 as a minimum). We should also switch from
`const std::string &` to `std::string_view` when switching to C++17 as a
minimum in the future. But, for now, I simply assumed support for
`std::string_view` (C++17) when using C++20 features, which is something
that should hopefully always work.

Run Details

108 of 150 new or added lines in 8 files covered. (72.0%)

4 existing lines in 2 files now uncovered.

11488 of 14032 relevant lines covered (81.87%)

1191666.72 hits per line