mindersec / minder / 13144603009
58%

DEFAULT BRANCH: main
Ran
Jobs 1
Files 321
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 57.482% (+0.01%) from 57.472%
13144603009

push

github

web-flow 
Refactor: Move Properties to pkg as Public API (#5402)

* Refactor: Move Properties to pkg as Public API

Properties are leveraged by many pieces of Minder, including providers, and should be considered a public API instead of being in our internal package.
The idea is to move properties to `pkg`.
However, the underlying service package will remain internal, as it is a minder-server implementation detail.

This commit fixes the affected functions to refer to the public API to access properties

Signed-off-by: Kugamoorthy Gajananan <gajananan@gmail.com>

* Refactor: Move Properties to pkg as Public API

Properties are leveraged by many pieces of Minder, including providers, and should be considered a public API instead of being in our internal package.
The idea is to move properties to `pkg`.
However, the underlying service package will remain internal, as it is a minder-server implementation detail.

This commit includes uncommitted changes found in the previous commit.  The was done aftering run 'make gen'.

Signed-off-by: Kugamoorthy Gajananan <gajananan@gmail.com>

* Refactor: Move Properties to pkg as Public API

Properties are leveraged by many pieces of Minder, including providers, and should be considered a public API instead of being in our internal package.
The idea is to move properties to `pkg`.
However, the underlying service package will remain internal, as it is a minder-server implementation detail.

This commit includes changes after running
1.  `make bootstrap` again to resolve conflicts in the following files
- internal/proto/internal.pb.go
- pkg/api/protobuf/go/minder/v1/minder.pb.go

2. `make gen`
Signed-off-by: Kugamoorthy Gajananan <gajananan@gmail.com>

---------

Signed-off-by: Kugamoorthy Gajananan <gajananan@gmail.com>

18136 of 31551 relevant lines covered (57.48%)

37.64 hits per line

Jobs
ID Job ID Ran Files Coverage
1 13144603009.1 321
57.48
 GitHub Action Run
Source Files on build 13144603009