tarantool / tarantool / 13130783069

86%

master: 88%

Build Type

push

github

Committed by locker

Commit Message

netbox: fix in-progress request counter underflow during schema fetch

If the remote schema changes while the client is fetching it, it will
restart the procedure. This effectively abandons the requests issued
in the previous attempt to fetch the schema. The server will still reply
to them though - when this happens, the client will subtract the counter
of in-progress requests, underflowing it, because these requests were
never accounted in the first place.

In case of a debug build, this bug results in a client crash due to an
assertion failure. In case of a release build, the client doesn't crash,
but the server will hang on shutdown because the counter is used for
implementing the graceful shutdown protocol.

Let's fix this issue by accounting these abandoned requests when
we restart fetching the remote schema.

Closes #11062

NO_DOC=bug fix

(cherry picked from commit 2df320405)

Run Details

63273 of 114549 branches covered (55.24%)

11 of 11 new or added lines in 1 file covered. (100.0%)

45 existing lines in 13 files now uncovered.

94153 of 109497 relevant lines covered (85.99%)

2324802.82 hits per line