rust-bitcoin / rust-bitcoin / 13103307326
83%

DEFAULT BRANCH: master
Ran
Jobs 1
Files 117
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 83.566% (-0.01%) from 83.576%
13103307326

push

github

apoelstra 
Merge rust-bitcoin/rust-bitcoin#3983: Add symmetrical fee calculation method to Weight

<a class=hub.com/rust-bitcoin/rust-bitcoin/commit/<a class="double-link" href="https://git"><a class=hub.com/rust-bitcoin/rust-bitcoin/commit/e91cb3ff7078277f5b173773263863fcaef47ae3">e91cb3ff7<a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/917149998bff8b2224e3c72bbdf73e029bb814df"> Run just check-api (jrakibi)
<a class="double-link" href="https://github.com/rust-bitcoin/rust-bitcoin/commit/134c1467489189ab821a5255ce7f122993028687">134c14674</a> Add Weight::checked_mul_by_fee_rate method (jrakibi)

Pull request description:

  Following up on #3736, this PR adds `checked_mul_by_fee_rate` to `Weight` to mirror the existing `checked_mul_by_weight` method on `FeeRate`.

  This makes the fee calculation more symmetrical.

  Changes:
  - Add `Weight::checked_mul_by_fee_rate` method
  - Add corresponding test cases

  The new method allows users to calculate fees starting from either Weight or FeeRate. This makes fee calculations more intuitive regardless of which type the user starts with.

  Closes #3766

ACKs for top commit:
  tcharding:
    ACK e91cb3ff7078277f5b173773263863fcaef47ae3
  apoelstra:
    ACK e91cb3ff7078277f5b173773263863fcaef47ae3; successfully ran local tests

Tree-SHA512: 10d17763aae13fe0b0e30b6837d4ab95221

0 of 3 new or added lines in 1 file covered. (0.0%)

21204 of 25374 relevant lines covered (83.57%)

17204.5 hits per line

Uncovered Changes

Lines Coverage ∆ File
3
92.06
 -2.25% units/src/fee.rs
Jobs
ID Job ID Ran Files Coverage
1 13103307326.1 117
83.57
 GitHub Action Run
Source Files on build 13103307326