supabase / supavisor / b77d19ae3552e72f2f1980e2643843c353e729d0-PR-580

47%

main: 65%

Build Type

Pull #580

github

Committed by hauleth

Commit Message

fix: more correct name validation

PostgreSQL requires that the DB name is a valid identifier

https://www.postgresql.org/docs/current/sql-syntax-lexical.html#SQL-SYNTAX-IDENTIFIERS

This was causing some issues with metrics gathering in the past, but
that should be resolved now. This makes it more in-line with what
PostgreSQL is allowing and expecting. The max length is compile-time
configurable, as PostgreSQL technically provides a way to increase the
byte limit, by default we use current PostgreSQL default there.

This mean that some users *may* be allowed to use weird names, but
assuming that Victoria Metrics is properly parsing exported metrics
using OpenMetrics specs, then it should work there.

Close #579

Pull Request Pull Request #580: fix: more correct DB name handling

Run Details

1 of 1 new or added line in 1 file covered. (100.0%)

5 existing lines in 1 file now uncovered.

958 of 2066 relevant lines covered (46.37%)

204.26 hits per line