fd919b85-9db6-4e7a-8b1a-a5b47c19ac15
93%

Ran 28 Jan 2025 07:54PM UTC

Jobs 1

Files 12

Run time 1min

Badge

Embed ▾

Committed 28 Jan 2025 07:52PM UTC coverage: 92.22% (-0.9%) from 93.088%

Build # fd919b85-9db6-4e7a-8b1a-a5b47c19ac15

Build Type

push

circleci

Committed by

snarfed

Commit Message

Repo.format_commit: don't read "missing" blocks from storage

seems unnecessary? https://discord.com/channels/1097580399187738645/1329137337711722536/1333883669554790483 :

> It records the MST before applying a commit, then applies it, then diffs the new MST against the original one. If it's missing any blocks in that difference, it reads them from storage. OK.
> ...but then all it does with them is write them back to storage. Where they already were.
> Maybe I want to get rid of it? Maybe I want to take the missing blocks from in memory, instead of reading them from storage where they might not exist?
> @retr0.id  fwiw I ran your MST test suite on this DatastoreStorage class, and removing this bit of code didn't introduce any new failures 🤷‍♂️

Run Details

1624 of 1761 relevant lines covered (92.22%)

0.92 hits per line

Uncovered Existing Lines

Lines	Coverage	∆	File
3	92.54	-0.7%	arroba/mst.py
12	68.38	-8.82%	arroba/diff.py

Jobs

ID	Job ID	Ran	Files	Coverage
1	fd919b85-9db6-4e7a-8b1a-a5b47c19ac15.1	28 Jan 2025 07:54PM UTC	12	92.22	CircleCI Job

snarfed / arroba / fd919b85-9db6-4e7a-8b1a-a5b47c19ac15
93%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Uncovered Existing Lines

Jobs

Source Files on build fd919b85-9db6-4e7a-8b1a-a5b47c19ac15

snarfed / arroba / fd919b85-9db6-4e7a-8b1a-a5b47c19ac15 93%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Uncovered Existing Lines

Jobs

Source Files on build fd919b85-9db6-4e7a-8b1a-a5b47c19ac15

snarfed / arroba / fd919b85-9db6-4e7a-8b1a-a5b47c19ac15
93%

README BADGES
x