rust-bitcoin / rust-bitcoin / 13011679647

83%

push

github

Merge rust-bitcoin/rust-bitcoin#3955: Refactor `LockTime` tests

<a class=hub.com/rust-bitcoin/rust-bitcoin/commit/<a class="double-link" href="https://git"><a class=hub.com/rust-bitcoin/rust-bitcoin/commit/bc8a378187b9fade96223c8ae9578b78f941f449">bc8a37818<a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/b99a81a0feab4a03d99c8a5698c41a607973bf8a"> Rename `day_` variables to `time_` (Jamil Lambert, PhD)
<a class="double-link" href="https://github.com/rust-bitcoin/rust-bitcoin/commit/922392268fce57ce40b57564379a3804cf395c2e">922392268</a><a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/b99a81a0feab4a03d99c8a5698c41a607973bf8a"> Combine satisfied by into singe tests (Jamil Lambert, PhD)
</a><a class="double-link" href="https://github.com/rust-bitcoin/rust-bitcoin/commit/33a7a35bbb6d486d8133ea41183b2f35a07b9f4c">33a7a35bb</a> Make naming consistent in tests (Jamil Lambert, PhD)

Pull request description:

  As mentioned in https://github.com/rust-bitcoin/rust-bitcoin/pull/3948#discussion_r1927690822 the variable naming in the tests in both `relative::LockTime` and `absolute::LockTime` is inconsistent and possibly confusing.

  Make variable names consistent.

  In `absolute::LockTime` incorporate the two standalone tests `satisfied_by_same` into `satisfied_by` to simplify the tests and conform to what is done in `relative::LockTime` .

ACKs for top commit:
  tcharding:
    ACK bc8a378187b9fade96223c8ae9578b78f941f449
  apoelstra:
    ACK bc8a378187b9fade96223c8ae9578b78f941f449; successfully ran local tests

Tree-SHA512: 643498e05b959d92077b74c8b7ff77ca15f

81 of 81 new or added lines in 2 files covered. (100.0%)

20943 of 25178 relevant lines covered (83.18%)

17324.6 hits per line