13007458387

Committed 28 Jan 2025 09:32AM UTC coverage: 93.368% (-0.01%) from 93.38%

Build # 13007458387

Build Type

push

github

Committed by

web-flow

Commit Message

Merge pull request #2679 from MushroomObserver/nimmo-lookups-PORO

New `Lookup` PORO

Coverage Stats

254 of 273 new or added lines in 16 files covered. (93.04%)

13 existing lines in 2 files now uncovered.

27282 of 29220 relevant lines covered (93.37%)

615.88 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

80.77

/app/classes/query/modules/lookup_objects.rb

# frozen_string_literal: true

# Helper methods to help parsing object instances from parameter strings.
module Query::Modules::LookupObjects
  def lookup_external_sites_by_name(vals)
    Lookup::ExternalSites.new(vals).ids
  end

  def lookup_herbaria_by_name(vals)
    Lookup::Herbaria.new(vals).ids
  end

  def lookup_herbarium_records_by_name(vals)
    Lookup::HerbariumRecords.new(vals).ids
  end

  def lookup_locations_by_name(vals)
    Lookup::Locations.new(vals).ids
  end

  def lookup_names_by_name(vals, params = {})
    Lookup::Names.new(vals, **params).ids
  end

  def lookup_projects_by_name(vals)
    Lookup::Projects.new(vals).ids
  end

  def lookup_lists_for_projects_by_name(vals)
    Lookup::ProjectSpeciesLists.new(vals).ids
  end

  def lookup_species_lists_by_name(vals)
    Lookup::SpeciesLists.new(vals).ids
  end

  def lookup_users_by_name(vals)
    Lookup::Users.new(vals).ids
  end

  # ------------------------------------------------------------------------

  private

  # `yield` means run the block provided to this method.
  # Only in the case it doesn't have an ID does it look up the record.
  def lookup_object_ids_by_name(vals)
    return unless vals

    vals.map do |val|
      if /^\d+$/.match?(val.to_s)
        val
      else
        yield(val).map(&:id)
      end
    end.flatten.uniq.compact
  end
end

1	# frozen_string_literal: true
2
3	# Helper methods to help parsing object instances from parameter strings.
4	module Query::Modules::LookupObjects	1✔
5	def lookup_external_sites_by_name(vals)	1✔
6	Lookup::ExternalSites.new(vals).ids	31✔
7	end
8
9	def lookup_herbaria_by_name(vals)	1✔
10	Lookup::Herbaria.new(vals).ids	776✔
11	end
12
13	def lookup_herbarium_records_by_name(vals)	1✔
14	Lookup::HerbariumRecords.new(vals).ids	617✔
15	end
16
17	def lookup_locations_by_name(vals)	1✔
18	Lookup::Locations.new(vals).ids	43✔
19	end
20
21	def lookup_names_by_name(vals, params = {})	1✔
22	Lookup::Names.new(vals, **params).ids	1,269✔
23	end
24
25	def lookup_projects_by_name(vals)	1✔
26	Lookup::Projects.new(vals).ids	1,312✔
27	end
28
29	def lookup_lists_for_projects_by_name(vals)	1✔
30	Lookup::ProjectSpeciesLists.new(vals).ids	542✔
31	end
32
33	def lookup_species_lists_by_name(vals)	1✔
34	Lookup::SpeciesLists.new(vals).ids	1,094✔
35	end
36
37	def lookup_users_by_name(vals)	1✔
38	Lookup::Users.new(vals).ids	2,067✔
39	end
40
41	# ------------------------------------------------------------------------
42
43	private	1✔
44
45	# `yield` means run the block provided to this method.
46	# Only in the case it doesn't have an ID does it look up the record.
47	def lookup_object_ids_by_name(vals)	1✔
UNCOV 48	return unless vals	×
49
UNCOV 50	vals.map do \|val\|	×
UNCOV 51	if /^\d+$/.match?(val.to_s)	×
UNCOV 52	val	×
53	else
UNCOV 54	yield(val).map(&:id)	×
55	end
56	end.flatten.uniq.compact
57	end
58	end

MushroomObserver / mushroom-observer / 13007458387

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous