Gallopsled / pwntools / 12948091350

19%

Build Type

push

github

Committed by web-flow

Commit Message

Allow to passthru kwargs on `ssh.__getattr__` convenience function to fix SSH motd problems (#2517)

* Allow to passthru kwargs on `ssh.__getattr__` convenience function

Instead of only passing the command arguments themselves to `ssh.system` when using `ssh.somecommand('args')`, allow to specify keyword arguments as well `ssh.somecommand('args', tty=False)`.

* ssh: Don't allocate a tty for internal state fetching

If the remote server is printing some motd agressively, this could lead to interpreting the motd instead of the requested output.

* Use `ssh.system` internally too instead of deprecated `ssh.run`

* Update CHANGELOG

Run Details

3789 of 6404 branches covered (59.17%)

9 of 10 new or added lines in 1 file covered. (90.0%)

19 existing lines in 5 files now uncovered.

13298 of 18082 relevant lines covered (73.54%)

0.74 hits per line