Qiskit / qiskit / 12891072018

88%

Build Type

push

github

Committed by web-flow

Commit Message

Bump PyO3 and rust-numpy to 0.23.x (#13577)

* Bump PyO3 and rust-numpy to 0.23.x

This commit bumps the version of pyo3 and rust-numpy used by qiskit to
the latest release 0.23. The largest change by volume of code is the
deprecation of all the `*_bound()` methods. These are just warnings but
they would be fatal to our CI so it needs to be updated. THe larger
functional change that required updating the code is the change in the
traits around converting to Python objects. This actually found a bug in
the target where we were not returning a proper instruction type for
standard gates. This also opens up the opportunity to update our
hashbrown version to 0.15.x, but we can't do that until the next
rustworkx-core release.

* Fix cache pygates build

* Fix cargo test

* Fix impl of IntoPyObject for target's operation

* Fix impl of IntoPyObject for equivalence library circuit

* Remove commented out code

* Fix commutation library conversion

* Fix conversion of qasm3 py register type

* Use into_py_any()

* Use borrowed instead of cloning py bound for NormalOperation

* Fix unitary synthesis failure

In pyo3 0.23 the behavior of the default conversion for a `SmallVec<u8>`
and similar arrays of u8 default to bytes objects when converted to
python. This was documented as an api change in the release, however it
was cauing the unitary synthesis test to fail because when we were
evaluating whether the synthesis was in terms of the natural direction
of the 2q gate on the backend it was evaluating `[0, 1] == b"\x00\x11"`
which evaluates to `False` and the pass flipped the direction of the
2q gate. This was causing the test failure because all the 2q gates
which were correctly directed were getting incorrectly flipped. This
commit fixes this by manually creating a pylist so the comparisons work
as expected.

* Fix cargo fmt

* Apply suggestions from code review

Co-authored-by: Kevin Hartman <kevin@hart.mn>

* Fix compilation error

* Use into_py_any in missed... (continued)

Run Details

870 of 1001 new or added lines in 58 files covered. (86.91%)

39 existing lines in 14 files now uncovered.

79463 of 89358 relevant lines covered (88.93%)

351805.32 hits per line