zalando / logbook / #4901

98%

master: 100%

push

Attempt to write a response log when flushBuffer() fails (#1997)

* Attempt to write a response log when flushBuffer() fails

In cases when a reactive client closes a connection, flushBuffer() operation may throw a "java.io.IOException: Broken pipe" exception, that in its own turn leads to a connection close, and `LogbookAsyncListener.onComplete` call. But as this happens AFTER `ServletResponse.freeResources()` is called (by HttpServerExchange.endExchange() in case of undertow, for example), the `responseWritingStageSynchronizationName` attribute is not present anymore in the response object, which leads to an NPE.
This fix attempts to overcome this edge case, by trying to write the response anyway, even after the flush fails.

* add isolated unit test

3 of 3 new or added lines in 1 file covered. (100.0%)

3669 of 3669 relevant lines covered (100.0%)

1.0 hits per line