safe-global / safe-client-gateway / 12870243599

88%

push

github

Deprecate `executedSurplusFee`, adding `executedFee` and `executedFeeToken` (#2247)

Deprecates `executedSurplusFee`, adding `executedFee` and `executedFeeToken` to `Order`s in its place:

- Add `executedFee`/`executedFeeToken` to `OrderSchema`.
- Add fields to relevant swap/TWAP entities, removing wrong nullable properties.
- Map new fields in respective swap/TWAP mappers.
- Update builder to use same values for `executedSurplusFee`<>`executedFee` and `sellToken`<>`executedFeeToken`.
- Update tests accordingly.

Eventually, the `executedFeeToken` will also need updating as it will will be expressed in SURPLUS tokens (BUY tokens for SELL orders and SELL tokens for BUY orders). For now, it remains the `sellToken`.

1047 of 1279 branches covered (81.86%)

Branch coverage included in aggregate %.

3383 of 3601 relevant lines covered (93.95%)

1374.43 hits per line