Qiskit / qiskit / 12833966079

88%

Build Type

push

github

Committed by web-flow

Commit Message

Include `&Packedinstruction` in `DAGCircuit::op_nodes` iteration (#13681)

Uses of the `DAGCircuit::op_nodes` iterator are almost invariably
followed by indexing into the DAG to retrieve the node weight, which is
dynamically asserted to be `NodeType::Operation`.  Since the iterator
already verifies this, we can just include the unwrapped
`&PackedInstruction` in the iterator return to simply calling code and
reduce the number of `unreachable!()`, `panic!()`, etcs.

A new `op_node_indices` is provided for ease for cases where the
iterator needs to be consumed to avoid being lifetime-tied to the DAG,
such as when the DAG is going to be mutated based on the nodes.

`topological_op_nodes` is left for a follow-up; it might be slightly
more challenging because of the interaction with rustworkx, but it can
also be done separately anyway.

Run Details

92 of 97 new or added lines in 11 files covered. (94.85%)

14 existing lines in 3 files now uncovered.

79433 of 89301 relevant lines covered (88.95%)

352943.27 hits per line