dart-lang / native / 12828848377

76%

push

github

[native_toolchain_c] Support Clang on Windows 2 (#1910)

Closes: https://github.com/dart-lang/native/issues/1892

Using clang on Windows requires being run with the windows dev environment _or_ an MSVC toolchain installed which is discoverable on the system.

On the GitHub bots, MSVC comes pre-installed, so we can't reproduce the case where Clang cannot find the MSVC dev environment.

I've tested this locally by (1) uninstalling visual studio, (2) seeing that the build with Clang fails, (3) hardcoding in a dev environment (from depot_tools) in `native_toolchain_c`, and (4) seeing that that the tests pass.

3 of 3 new or added lines in 2 files covered. (100.0%)

7700 of 8496 relevant lines covered (90.63%)

54.13 hits per line