12827063919
78%
master: 80%

Ran 17 Jan 2025 10:16AM UTC

Jobs 1

Files 37

Run time 6min

Badge

Embed ▾

Committed 16 Jan 2025 04:11PM UTC coverage: 78.273%. Remained the same

Build # 12827063919

Build Type

push

github

Committed by

web-flow

Commit Message

CA-404597 - rrd: Fix incorrect processing of Gauge and Absolute data sources (#6233)

Some recent changes related to RRDs likely exposed a long-standing
latent issue
where the RRD library would process the passed-in values for Gauge and
Absolute
data sources incorrectly leading to constant values changing from update
to
update, for example:
```
$ rrd2csv memory_total_kib
timestamp, AVERAGE:host:8b533333-91e1-4698-bd17-95b9732ffbb6:memory_total_kib
2025-01-15T08:41:40Z, 33351000
2025-01-15T08:41:45Z, 33350000
2025-01-15T08:41:50Z, 33346000
2025-01-15T08:41:55Z, 33352000
```

Instead of treating Gauge and Absolute data sources as a
variation on the rate-based Derive data source type, expecting
time-based
calculations to cancel each other out, do not undertake any calculations
on
non-rate data sources at all.

First commit adds a failing unit test, second makes it pass.

===

I've verified these changes through manual testing, they've also passed
the testcases that discovered this issue: SNMP memory testcases (JobIDs
4197305, 4196759, 4196744) and ShimMemory testcase (4197050). This
branch also passed Ring3 BST+BVT (210577)

Run Details

3462 of 4423 relevant lines covered (78.27%)

0.78 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
1	python3.11 - 12827063919.1	17 Jan 2025 10:16AM UTC	37	78.27	GitHub Action Run

xapi-project / xen-api / 12827063919
78%
master: 80%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 12827063919

xapi-project / xen-api / 12827063919 78% master: 80%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 12827063919

xapi-project / xen-api / 12827063919
78%
master: 80%

README BADGES
x