payjoin / rust-payjoin / 12814449771

83%

Build Type

push

github

Committed by web-flow

Commit Message

Separate receive::{v1,v2} error modules (#482)

This big move isolates v1/v2 module-specific error variants into clean
module v1/v2 error modules.

There are probably too many `impl<From>` for error variants, but this
addresses the module structure first with this PR and will be followed by
taking a magnifying glass to the way specific variants are handled.

This still also leaves `OutputSubstitutionError`, `SelectionError` and
`InputContributionError` from producing JSON error responses to cancel a
session with a v2 receiver. We're going to need to address that as part
of #403. v2 Error variants also improperly produce JSON errors, but I
think the way this was done by abusing `fmt::Display` is also an
antipattern to fix at the same time that's addressed. I'd like to leave
the JSON receiver error fixes to a follow up since what gets revealed is
potentially sensitive and we should be reviewing that change with extra
scrutiny.

See: #312, #392, #403

Run Details

48 of 188 new or added lines in 7 files covered. (25.53%)

2 existing lines in 2 files now uncovered.

2947 of 4872 relevant lines covered (60.49%)

950.32 hits per line